MigrationAssistant - Feature: Set desired count for proxies #10082
+22
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andre Kurait <akurait@amazon.com>
AndreKurait
requested review from
kolchfa-aws,
Naarcha-AWS,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Naarcha-AWS
reviewed
Jun 12, 2025
_migration-assistant/deploying-migration-assistant/configuration-options.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Naarcha-AWS
reviewed
Jun 13, 2025
_migration-assistant/deploying-migration-assistant/configuration-options.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Naarcha-AWS
reviewed
Jun 13, 2025
_migration-assistant/deploying-migration-assistant/configuration-options.md
Outdated
Show resolved
Hide resolved
Naarcha-AWS
reviewed
Jun 13, 2025
_migration-assistant/deploying-migration-assistant/configuration-options.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
|
Moving to draft until opensearch-project/opensearch-migrations#1499 is released |
peternied
reviewed
Jun 18, 2025
_migration-assistant/deploying-migration-assistant/configuration-options.md
Outdated
Show resolved
Hide resolved
Naarcha-AWS
approved these changes
Jun 27, 2025
Naarcha-AWS
reviewed
Jun 27, 2025
_migration-assistant/deploying-migration-assistant/configuration-options.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Naarcha-AWS
added
5 - Editorial review
|
@natebower: Can you take a quick look at this one? |
natebower
requested changes
Jun 30, 2025
There was a problem hiding this comment.
@Naarcha-AWS @AndreKurait Please see my comment and changes and tag me for approval when addressed. Thanks!
_migration-assistant/deploying-migration-assistant/configuration-options.md
Outdated
Show resolved
Hide resolved
_migration-assistant/deploying-migration-assistant/configuration-options.md
Outdated
Show resolved
Hide resolved
_migration-assistant/deploying-migration-assistant/configuration-options.md
Outdated
Show resolved
Hide resolved
_migration-assistant/deploying-migration-assistant/configuration-options.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Naarcha-AWS
reviewed
Jun 30, 2025
_migration-assistant/deploying-migration-assistant/configuration-options.md
Outdated
Show resolved
Hide resolved
…on-options.md Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
natebower
added
4 - Doc review
|
@Naarcha-AWS @AndreKurait Moved back to doc review pending completion. |
…Count to be 0 Signed-off-by: Andre Kurait <akurait@amazon.com>
…proxy Signed-off-by: Andre Kurait <akurait@amazon.com>
|
@natebower i've updated based on feedback here, could you take another look? |
natebower
reviewed
Jul 8, 2025
There was a problem hiding this comment.
@AndreKurait Please see my comment and a minor change. We can proceed based on the answer to my comment. Thanks!
_migration-assistant/deploying-migration-assistant/configuration-options.md
Outdated
Show resolved
Hide resolved
| "captureProxyServiceEnabled": true, | ||
| "captureProxyExtraArgs": "", | ||
|
|
||
| "// settingsForCaptureAndReplay": "Enable the following services for live traffic capture and replay", |
There was a problem hiding this comment.
@AndreKurait What is the source of this text? Is it a template? Shouldn't the text in the code block reflect exactly what the user will see in the sample CDK? In other words, are we allowed to change this text or not?
There was a problem hiding this comment.
Once we merge this, i'll merge a correction in the sample CDK to match this exactly
…on-options.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Andre Kurait <AndreKurait@gmail.com>
natebower
reviewed
Jul 8, 2025
_migration-assistant/deploying-migration-assistant/configuration-options.md
Outdated
Show resolved
Hide resolved
_migration-assistant/deploying-migration-assistant/configuration-options.md
Outdated
Show resolved
Hide resolved
_migration-assistant/deploying-migration-assistant/configuration-options.md
Outdated
Show resolved
Hide resolved
…on-options.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Andre Kurait <AndreKurait@gmail.com>
…on-options.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Andre Kurait <AndreKurait@gmail.com>
…on-options.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Andre Kurait <AndreKurait@gmail.com>
natebower
approved these changes
Jul 8, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
* MigrationAssistant - Feature: Set desired count for proxies Signed-off-by: Andre Kurait <akurait@amazon.com> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Update _migration-assistant/deploying-migration-assistant/configuration-options.md Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> * Update example targetClusterProxyDesiredCount and captureProxyDesiredCount to be 0 Signed-off-by: Andre Kurait <akurait@amazon.com> * Improve language on preventing failing deployments on capture/target proxy Signed-off-by: Andre Kurait <akurait@amazon.com> * Update _migration-assistant/deploying-migration-assistant/configuration-options.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Andre Kurait <AndreKurait@gmail.com> * Update _migration-assistant/deploying-migration-assistant/configuration-options.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Andre Kurait <AndreKurait@gmail.com> * Update _migration-assistant/deploying-migration-assistant/configuration-options.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Andre Kurait <AndreKurait@gmail.com> * Update _migration-assistant/deploying-migration-assistant/configuration-options.md Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: Andre Kurait <AndreKurait@gmail.com> --------- Signed-off-by: Andre Kurait <akurait@amazon.com> Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Andre Kurait <AndreKurait@gmail.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Co-authored-by: Nathan Bower <nbower@amazon.com> (cherry picked from commit 34daa48) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add documentation for feature in PR: opensearch-project/opensearch-migrations#1499
Issues Resolved
Closes #MIGRATIONS-2515
Version
MA 2.4.1+
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.